Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UTOPIA-1177] added CPO review columns + deleted reviews by other user fix + tests #1447

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

kushal-arora-fw
Copy link
Contributor

Description

This PR includes the following proposed change(s):

  • Added CPO Review columns
  • Update CPO review system generated submission fields
  • Updated Program Area reviews: One users cannot delete other users review: fix
  • Appropriate tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

by adding suitable test cases; and by locally getting UTOPIA-1178

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@@ -15,47 +15,63 @@ export const mpoReviewMetadata: Array<IFormField<MpoReview>> = [
key: 'isAcknowledged',
type: 'boolean',
allowedUserTypesEdit: [UserTypesEnum.MPO],
isSystemGeneratedField: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be ok to add a comment on what isSystemGeneratedField does or it's purpose ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. Done. Added at the definition file - form-field.interface.ts

@bcgov bcgov deleted a comment from github-actions bot Aug 3, 2023
@bcgov bcgov deleted a comment from github-actions bot Aug 3, 2023
@kushal-arora-fw kushal-arora-fw merged commit 7aca657 into main Aug 3, 2023
7 of 8 checks passed
@kushal-arora-fw kushal-arora-fw deleted the utopia-1177 branch August 3, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA API PR contains changes to DPIA API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants